libosmocore[master]: vty: derive node name from prompt, use as XML ids

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Wed Sep 20 03:15:54 UTC 2017


Patch Set 3: Code-Review+1

(2 comments)

You don't mention "duplicate" avoidance. I don't think we should derive it from the prompt...

https://gerrit.osmocom.org/#/c/3979/3/src/vty/command.c
File src/vty/command.c:

Line 158: 	if (!*node->name)
use node->name[0]? But why derive it from the prompt? It seems like an interim solution only?


Line 612: 		same_name_count = 1;
Why start with 1? For the first node it has not used before?


-- 
To view, visit https://gerrit.osmocom.org/3979
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8fa555570268b231c5e01727c661da92fad265de
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list