[PATCH] osmo-msc[master]: main: remove cmdline args no longer available for osmo-msc

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Sep 18 21:51:22 UTC 2017


Review at  https://gerrit.osmocom.org/3980

main: remove cmdline args no longer available for osmo-msc

Change-Id: I3009d2b3dd89eacdf6bc3d9c19744e9fdf4be6c3
---
M src/osmo-msc/msc_main.c
1 file changed, 1 insertion(+), 27 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/80/3980/1

diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c
index bbf35b8..5c192e8 100644
--- a/src/osmo-msc/msc_main.c
+++ b/src/osmo-msc/msc_main.c
@@ -115,19 +115,6 @@
 
 static struct osmo_timer_list db_sync_timer;
 
-static void create_pcap_file(char *file)
-{
-	mode_t mode = S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH;
-	int fd = open(file, O_WRONLY|O_TRUNC|O_CREAT, mode);
-
-	if (fd < 0) {
-		perror("Failed to open file for pcap");
-		return;
-	}
-
-	e1_set_pcap_fd(fd);
-}
-
 static void print_usage()
 {
 	printf("Usage: osmo-nitb\n");
@@ -144,13 +131,10 @@
 	printf("  -l --database db-name      The database to use.\n");
 	printf("  -T --timestamp             Prefix every log line with a timestamp.\n");
 	printf("  -V --version               Print the version of OpenBSC.\n");
-	printf("  -P --rtp-proxy             Enable the RTP Proxy code inside OpenBSC.\n");
 	printf("  -e --log-level number      Set a global loglevel.\n");
 	printf("  -M --mncc-sock-path PATH   Disable built-in MNCC handler and offer socket.\n");
 	printf("  -m --mncc-sock             Same as `-M /tmp/bsc_mncc' (deprecated).\n");
 	printf("  -C --no-dbcounter          Disable regular syncing of counters to database.\n");
-	printf("  -r --rf-ctl PATH           A unix domain socket to listen for cmds.\n");
-	printf("  -p --pcap PATH             Write abis communication to pcap trace file.\n");
 }
 
 static void handle_options(int argc, char **argv)
@@ -164,10 +148,8 @@
 			{"config-file", 1, 0, 'c'},
 			{"disable-color", 0, 0, 's'},
 			{"database", 1, 0, 'l'},
-			{"pcap", 1, 0, 'p'},
 			{"timestamp", 0, 0, 'T'},
 			{"version", 0, 0, 'V' },
-			{"rtp-proxy", 0, 0, 'P'},
 			{"log-level", 1, 0, 'e'},
 			{"mncc-sock", 0, 0, 'm'},
 			{"mncc-sock-path", 1, 0, 'M'},
@@ -175,7 +157,7 @@
 			{0, 0, 0, 0}
 		};
 
-		c = getopt_long(argc, argv, "hd:Dsl:ap:TPVc:e:mCM:",
+		c = getopt_long(argc, argv, "hd:Dsl:TVc:e:mCM:",
 				long_options, &option_index);
 		if (c == -1)
 			break;
@@ -200,17 +182,9 @@
 		case 'c':
 			msc_cmdline_config.config_file = optarg;
 			break;
-		case 'p':
-			create_pcap_file(optarg);
-			break;
 		case 'T':
 			log_set_print_timestamp(osmo_stderr_target, 1);
 			break;
-#if BEFORE_MSCSPLIT
-		case 'P':
-			ipacc_rtp_direct = 0;
-			break;
-#endif
 		case 'e':
 			log_set_log_level(osmo_stderr_target, atoi(optarg));
 			break;

-- 
To view, visit https://gerrit.osmocom.org/3980
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3009d2b3dd89eacdf6bc3d9c19744e9fdf4be6c3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list