This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has submitted this change and it was merged. Change subject: smpp34_unpack.c: remove unused variable ...................................................................... smpp34_unpack.c: remove unused variable Fixes compilation warning below: /home/pespin/dev/sysmocom/bin/../git/libsmpp34/src/smpp34_unpack.c: In function ‘smpp34_unpack’: /home/pespin/dev/sysmocom/bin/../git/libsmpp34/src/smpp34_unpack.c:232:18: warning: variable ‘l’ set but not used [ -Wunused-but-set-variable] uint32_t l; Change-Id: I75baa65b575deec1cc040490f2e76ebb54e46ca7 --- M src/smpp34_unpack.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/smpp34_unpack.c b/src/smpp34_unpack.c index f498d01..3d8b0f8 100644 --- a/src/smpp34_unpack.c +++ b/src/smpp34_unpack.c @@ -229,9 +229,7 @@ { /* Hace algunas Verificaciones **************************************/ uint32_t len_orig; - uint32_t l; memcpy(&len_orig, tt, sizeof(uint32_t)); - l = ntohl( len_orig ); if( len_orig != (aux - ini) ){ PUTLOG("[%s:(Error in PDU length %d!=%d)]",PDU,len_orig,(uint32_t)(aux-ini)); return( -1 ); -- To view, visit https://gerrit.osmocom.org/3967 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75baa65b575deec1cc040490f2e76ebb54e46ca7 Gerrit-PatchSet: 1 Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>