[MERGED] libsmpp34[master]: smpp34_structs.h: Fix truncated output in str_tlv_id

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged.

Change subject: smpp34_structs.h: Fix truncated output in str_tlv_id
......................................................................


smpp34_structs.h: Fix truncated output in str_tlv_id

Fixes compilation warning below:

%s’ directive output may be truncated writing between 8 and 33 bytes into a regio
n of size 30 [-Wformat-truncation=]
     snprintf(buff, SMALL_BUFF, "%s",
                                 ^~
/home/pespin/dev/sysmocom/bin/../git/libsmpp34/src/smpp34_params.c:136:5: note: ‘
snprintf’ output between 9 and 34 bytes into a destination of size 30
     snprintf(buff, SMALL_BUFF, "%s",
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 #define OPERACION( p_tlv_id ) (tlv_id == p_tlv_id)?#p_tlv_id:
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 #include "def_list/tlv_id.list"
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             "Reserved"
             ~~~~~~~~~~
 #undef OPERACION
 ~~~~~~~~~~~~~~~~
           );

Change-Id: Ie2ba6182eb0cdd98cadb8317aef49141244aa92d
---
M src/smpp34_structs.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/smpp34_structs.h b/src/smpp34_structs.h
index 6b9f41e..71d22cd 100644
--- a/src/smpp34_structs.h
+++ b/src/smpp34_structs.h
@@ -23,7 +23,7 @@
 #ifndef _STB_H_
 #define _STB_H_
 
-#define SMALL_BUFF      30
+#define SMALL_BUFF      34
 /* Identify PDUs ident ********************************************************/
 #define MAX_TLV_SIZE         1024
 #define MAX_DAD_SIZE         21

-- 
To view, visit https://gerrit.osmocom.org/3966
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2ba6182eb0cdd98cadb8317aef49141244aa92d
Gerrit-PatchSet: 1
Gerrit-Project: libsmpp34
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>