This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
André Boddenberg gerrit-no-reply at lists.osmocom.orgPatch Set 4: (9 comments) Thanks for the review, all comments/changes will be applied. Let's submit/merge afterwards! >> and let's add a jobs/README that describes how these yml >> files are used to update our jenkins jobs Good idea, will be done. I also would like to move lynxis osmo-nitb.yaml file to jobs/ ? https://gerrit.osmocom.org/#/c/3911/4/jobs/gerrit-verifications.yml File jobs/gerrit-verifications.yml: Line 3: # following default values can be overridden by each repo > by repo you mean the individual projects listed below in this file? (and no Yes, the repositories/projects (line 21 to 185) Line 8: slave_axis: !!python/tuple [linux_amd64_debian8] > wondering about the '!!python/tuple', is that really needed? A normal list I totally agree, it would be less cumbersome without the !!python/tuple, but I didn't manage to move it to the job-template. The JJB example [1] does the same, so I guess it's the way it is. [1] https://docs.openstack.org/infra/jenkins-job-builder/definition.html#variable-references Line 25: > (whitespace) ooops, will be removed. Line 26: # no 'clean state'? > clean state sounds like we want it. If it's missing, let's add it? Sure, the template actually adds it for all jobs, but I simply wanted to point out the difference. Line 38: # no gcc warnings at all? > are you referring to the post-build step of evaluating gcc warnings? AFAICT Yes, it's about the post-build step. Cannot say anything about the value of its output. Line 80: combination_filter: '(BTS_MODEL == "sysmo" && FIRMWARE_VERSION=="master") || (BTS_MODEL == "oct" && FIRMWARE_VERSION=="master") || (BTS_MODEL == "trx" && FIRMWARE_VERSION=="master") || (BTS_MODEL == "oct+trx" && FIRMWARE_VERSION=="master") || (BTS_MODEL == "lc15" && FIRMWARE_VERSION=="master") || (BTS_MODEL == "sysmo" && FIRMWARE_VERSION=="femtobts_v2.7") || (BTS_MODEL == "sysmo" && FIRMWARE_VERSION=="superfemto_v2.4") || (BTS_MODEL == "sysmo" && FIRMWARE_VERSION=="superfemto_v3.0.1pre") || (BTS_MODEL == "sysmo" && FIRMWARE_VERSION=="superfemto_v3.1") || (BTS_MODEL == "sysmo" && FIRMWARE_VERSION=="superfemto_v5.1") || (BTS_MODEL == "lc15" && FIRMWARE_VERSION=="v2017.01") || (BTS_MODEL == "lc15" && FIRMWARE_VERSION=="origin/nrw/litecell15-next")' > does yaml allow breaking long lines like this up into several lines? Would Yes, will try to keep in the 120 char rule. Maybe expression can be shortened by using '!'. Line 119: ./contrib/jenkins-arm.sh > (noting a mix of spaces and tabs, maybe rather avoid that) Good point, would personally like to stay with tabs, but YAML needs blanks afaik, so no tabs it is! Line 246: - branch-compare-type: 'ANT' > ANT? that's the web UI's 'Path' value? Yes, confused me too. :) Jenkins terms: Plain, Path, RegExp jjb terms: PLAIN, ANT, REG_EXP https://docs.openstack.org/infra/jenkins-job-builder/triggers.html Line 261: - shell: 'chmod -R +w *; rm -rf *; git checkout .' > could also be done by the Git SCM plugin "Clean before checkout" Good point, will (try) to put it there. -- To view, visit https://gerrit.osmocom.org/3911 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04387367a6e2d737bfb50423c81a8908d3c2a89f Gerrit-PatchSet: 4 Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Owner: André Boddenberg <dr.blobb at gmail.com> Gerrit-Reviewer: André Boddenberg <dr.blobb at gmail.com> Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes