This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Patch Set 3:
(3 comments)
https://gerrit.osmocom.org/#/c/3907/3/selftest/suite_test/test_suite/suite.conf
File selftest/suite_test/test_suite/suite.conf:
Line 6: - times: 2
> it would serve to see which one of them got duplicated :)
This is left like this in the new version of the patch because actually other bugs (fixed in next commits) prevent from tests passing if there are other keys in this dictionary. A extra commit is added after the commits that fix bugs in order to improve the test.
https://gerrit.osmocom.org/#/c/3907/3/src/osmo_gsm_tester/resource.py
File src/osmo_gsm_tester/resource.py:
Line 61: 'bts[].trx_list[].nominal_power': schema.INT,
> hw_addr and net_device will, IIRC, be useful for octphy.
I finally moved this to a new commit before this one, fixing usage of max_red_power too.
https://gerrit.osmocom.org/#/c/3907/3/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:
Line 212: combination = config.replicate_times(self.definition.conf.get(conf_name, {}))
> Good point. I'll have a look and do some tests and I'll come with an answer
This has been removed in the new version of the commit, because indeed it's not needed. A bit of extra stuff is done in the new version too to accommodate schema requirements after the change.
--
To view, visit https://gerrit.osmocom.org/3907
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25eb639c7e3cf3b4c67a205422808bffbdd791e6
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes