This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 1: Code-Review+2
(4 comments)
https://gerrit.osmocom.org/#/c/3948/1/src/sccp_user.c
File src/sccp_user.c:
Line 418: * the default asp name. */
thinking ... if I've added an ASP for a *different* AS but stupidly enough chose the same name, we're now stealing the ASP from the other AS, right? Maybe we need to also check that this other ASP does not belong to a different AS yet. Rather do this in a separate patch I guess.
All in all this amount of complexity is what I'd have preferred to avoid altogether. But by now I see that it is convenient for the user to have this magic in place, so it might be worth the trouble after all.
Line 423: name);
(could stay in one line)
Line 434: asp->cfg.local.host = NULL;
you really don't like the 'A ? B : C' notation, do you? :)
Bloating up two lines to 10, but fine.
Line 436: if (default_local_ip) {
(could drop the { } braces since it's just one line, and could not break the assignment across two lines; we decided for 120 chars line width some weeks ago)
--
To view, visit https://gerrit.osmocom.org/3948
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53d73059f804c3bbea6cb43dc73ad49a753b3b15
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes