This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 4: Code-Review+2 (7 comments) all of these can be addressed after this is merged. https://gerrit.osmocom.org/#/c/3911/4/jobs/gerrit-verifications.yml File jobs/gerrit-verifications.yml: Line 3: # following default values can be overridden by each repo by repo you mean the individual projects listed below in this file? (and not external files from other repositories?) Line 8: slave_axis: !!python/tuple [linux_amd64_debian8] wondering about the '!!python/tuple', is that really needed? A normal list [a, b] would be much simpler to write and read. At least in python, tuple and list are pretty much interchangeable (except for the mutability) Line 25: (whitespace) Line 26: # no 'clean state'? clean state sounds like we want it. If it's missing, let's add it? Line 38: # no gcc warnings at all? are you referring to the post-build step of evaluating gcc warnings? AFAICT that plugin produces garbage and counts pretty much any output as warning. Line 80: combination_filter: '(BTS_MODEL == "sysmo" && FIRMWARE_VERSION=="master") || (BTS_MODEL == "oct" && FIRMWARE_VERSION=="master") || (BTS_MODEL == "trx" && FIRMWARE_VERSION=="master") || (BTS_MODEL == "oct+trx" && FIRMWARE_VERSION=="master") || (BTS_MODEL == "lc15" && FIRMWARE_VERSION=="master") || (BTS_MODEL == "sysmo" && FIRMWARE_VERSION=="femtobts_v2.7") || (BTS_MODEL == "sysmo" && FIRMWARE_VERSION=="superfemto_v2.4") || (BTS_MODEL == "sysmo" && FIRMWARE_VERSION=="superfemto_v3.0.1pre") || (BTS_MODEL == "sysmo" && FIRMWARE_VERSION=="superfemto_v3.1") || (BTS_MODEL == "sysmo" && FIRMWARE_VERSION=="superfemto_v5.1") || (BTS_MODEL == "lc15" && FIRMWARE_VERSION=="v2017.01") || (BTS_MODEL == "lc15" && FIRMWARE_VERSION=="origin/nrw/litecell15-next")' does yaml allow breaking long lines like this up into several lines? Would be good to stay below 120. Ah, like that 'cmd: >' below would be nice. Line 119: ./contrib/jenkins-arm.sh (noting a mix of spaces and tabs, maybe rather avoid that) -- To view, visit https://gerrit.osmocom.org/3911 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04387367a6e2d737bfb50423c81a8908d3c2a89f Gerrit-PatchSet: 4 Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Owner: André Boddenberg <dr.blobb at gmail.com> Gerrit-Reviewer: André Boddenberg <dr.blobb at gmail.com> Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes