[PATCH] libosmo-netif[master]: src: _snprintf() helper functions always nul-terminate buffers

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pablo Neira Ayuso gerrit-no-reply at lists.osmocom.org
Tue Sep 12 10:50:54 UTC 2017


Hello Pau Espin Pedrol, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/3830

to look at the new patch set (#2).

src: _snprintf() helper functions always nul-terminate buffers

This patch inconditionally initializes the buffer we get to
nul-terminated, it's a very simple solution to catch two overly corner
cases:

1) snprintf() returns -1, very much unlikely in practise.

2) msg->len == 0: In such case, I would expect this function is never
   called with an empty message, but let's be safe in this case too.

Change-Id: I97e517f2d98e83894ea707c63489559302ff6bd2
---
M src/osmux.c
M src/rtp.c
2 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/30/3830/2

diff --git a/src/osmux.c b/src/osmux.c
index b18246f..47def14 100644
--- a/src/osmux.c
+++ b/src/osmux.c
@@ -902,6 +902,8 @@
 	int msg_len = msg->len;
 	int ret;
 
+	buf[0] = '\0';
+
 	while (msg_len > 0) {
 		if (msg_len < sizeof(struct osmux_hdr)) {
 			LOGP(DLMIB, LOGL_ERROR,
diff --git a/src/rtp.c b/src/rtp.c
index 56fc37c..38bee3a 100644
--- a/src/rtp.c
+++ b/src/rtp.c
@@ -200,6 +200,8 @@
 	uint8_t *payload;
 	int ret, i;
 
+	buf[0] = '\0';
+
 	rtph = osmo_rtp_get_hdr(msg);
 	if (rtph == NULL)
 		return -1;

-- 
To view, visit https://gerrit.osmocom.org/3830
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I97e517f2d98e83894ea707c63489559302ff6bd2
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Owner: Pablo Neira Ayuso <pablo at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pablo Neira Ayuso <pablo at gnumonks.org>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>



More information about the gerrit-log mailing list