osmo-gsm-tester[master]: modem: Fix race condition when connect() is called more than...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Sep 11 12:36:06 UTC 2017


Patch Set 2: Code-Review-1

(3 comments)

(sorry, comments on old patch set, but still apply)

-1 for the NoneType / missing None, otherwise ok. The sleep can be replaced as a separate issue, some time.

https://gerrit.osmocom.org/#/c/3901/1/src/osmo_gsm_tester/ofono_client.py
File src/osmo_gsm_tester/ofono_client.py:

Line 357:     def properties(self, *args, **kwargs):
IMHO this entire if.. including 'self.cancellable = None' should move into the new function


Line 524:         self.cancel_pending_dbus_methods()
because now we're potentially causing a NoneType exception or forget to reset self.cancellable


https://gerrit.osmocom.org/#/c/3901/1/suites/aoip_encryption/register_a5_0_authreq.py
File suites/aoip_encryption/register_a5_0_authreq.py:

Line 34: sleep(40) # TODO: read pcap or CTRL interface and look for Rejected? (gsm_a.dtap.msg_mm_type == 0x04)
in general, if at all possible, we should avoid arbitrary sleeps, we can never know how long a modem will cycle around to scan... since we expect a LU reject here it would indeed be nice to detect a rejection. But is this possible with the CTRL? (listening for TRAPs / add a "rejected" flag to VLR subscriber and provide a new CTRL cmd for it) ... The easiest dirty hack I can think of is grepping the osmo-msc stderr.


-- 
To view, visit https://gerrit.osmocom.org/3901
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4bb1c6b72c23cd860c33bee7851bca3d0ac0e1b
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list