This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: ctrl: subscriber-list-active: list only attached subscribers ...................................................................... ctrl: subscriber-list-active: list only attached subscribers I would have liked to add a regression test to verify this, but currently there is no easy way to run CTRL tests and at the same time have access to the osmo-msc in a way that simulates an attached subscriber. Related: OS#2285 Change-Id: I003542b208ecf3713e9e67712d84ccb4c61af14e --- M src/libmsc/ctrl_commands.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libmsc/ctrl_commands.c b/src/libmsc/ctrl_commands.c index 7e445aa..4767ddd 100644 --- a/src/libmsc/ctrl_commands.c +++ b/src/libmsc/ctrl_commands.c @@ -68,6 +68,9 @@ cmd->reply = talloc_strdup(cmd, ""); llist_for_each_entry(vsub, &msc_ctrl_net->vlr->subscribers, list) { + /* Do not list subscribers that aren't successfully attached. */ + if (!vsub->lu_complete) + continue; cmd->reply = talloc_asprintf_append(cmd->reply, "%s,%s\n", vsub->imsi, vsub->msisdn); } -- To view, visit https://gerrit.osmocom.org/3898 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I003542b208ecf3713e9e67712d84ccb4c61af14e Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder