osmo-pcu[master]: TS alloc: use standard function

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Sat Sep 9 18:21:57 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/3896/1/src/pcu_utils.h
File src/pcu_utils.h:

Line 46
I just discovered about the existence of this ffs() function in glibc, first time I heard about it.

I didn't look in detail at it as I don't know much about the context, but the ffs function you are using to replace this pcu_lsb() seems to be doing more stuff, so not sure if the returned result will be the same. See https://github.com/lattera/glibc/blob/master/string/ffs.c


-- 
To view, visit https://gerrit.osmocom.org/3896
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d14ef327b09173d56ee3bca7e3ca85897d381c7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list