This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPatch Set 1: (4 comments) https://gerrit.osmocom.org/#/c/3894/1/src/osmo_gsm_tester/bts_osmotrx.py File src/osmo_gsm_tester/bts_osmotrx.py: Line 44: self.pcu_sk_tmp_dir = tempfile.mkdtemp(None, 'ogtpcusk', None) > lol, what is octopusk? ogt -> OsmoGsmTester pcu-> pcu sk -> socket (normal abreviation used a lot in the kernel for instance). As we have constraint amount of bytes to use, the less the better while keeping enough info to match directories in /tmp to know they are there to hold pcu sockets for osmo-sgsm-tester. But I don't really want to spend time discussing on this kind of stuff, so I can change it to "osmo-gsm-tester_" if you think it's a blocker. (underscore is there to easily differentiate it from /var/tmp/osmo-gsm-tester/ we use for resource state lock file). Line 52: except OSError: > for completeness sake we could log the error. not very important though. Not needed, it can be expected that the pcu socket is not there, for instance if osmo-bts-trx crashed or was stopped before creating it. In this case, the crash error is printed and we arrive here through cleanup() process. Line 54: os.rmdir(self.pcu_sk_tmp_dir) > what if removing the socket file failed or the dir is nonempty for any odd IMHO we want to crash the test too, as there's something not going as expected. Removing the file should not fail, and removing the dir should not fail neither, because in this case we leak a dir in /tmp and we don't want that, so we should be alerted. Line 56: def pcu_socket_path(self): > small cosmetic: first init self.pcu_sk_tmp_dir with None and create the dir I actually prefer having it in the constructor to fail beforehand, but if you insist I can move it here. -- To view, visit https://gerrit.osmocom.org/3894 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c53a0a3ccc5eb2823265fe14c0f7b8f4adb1038 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-HasComments: Yes