This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review+1 (5 comments) https://gerrit.osmocom.org/#/c/3889/1/src/libmsc/a_iface.c File src/libmsc/a_iface.c: Line 146: msg_resp = gsm0808_create_dtap(msg, link_id); ( below msgb_free(msg) could go up here, then no need to call in both if() paths below ) Line 147: (unrelated whitespace) Line 153: LOGP(DMSC, LOGL_DEBUG, "Massage will be sent as BSSMAP DTAP message!\n"); yay, I could use a massage! https://gerrit.osmocom.org/#/c/3889/1/src/libmsc/a_iface_bssap.c File src/libmsc/a_iface_bssap.c: Line 331: rc = msc_compl_l3(conn, msg, 0); ( below msgb_free(msg) could go up here, then no need to call in both if() paths below ) Line 700: return -EINVAL; good catch! looks like a potential attack door just got closed. -- To view, visit https://gerrit.osmocom.org/3889 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90703c96e6a266a1cfa60b184139375aeb9ae32d Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes