This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: > does this also work with the .LINE syntax of the parser Good point, had to check which way it goes. A comment character after space is stronger than the .LINE token, because we stop parsing tokens from the input str altogether. i.e. OsmoMSC# subscriber id 1 sms sender id 2 send yada foo ! comment % sending 'yada foo' This means after this patch we can't by VTY send SMS that contain ' #' or ' !' anymore. OTOH #1: a real programmatic SMS dispatcher shouldn't use the VTY to begin with, rather SMPP; #2: a '!' is still allowed at the end of a sentence: OsmoMSC# subscriber id 1 sms sender id 2 send your phone is burning! stop drop and roll! % sending 'your phone is burning! stop drop and roll!' (no comments here because no space before the '!') The only other instances of .LINE in use I can find: e1_line <0-255> name .LINE For the e1_line name it's more likely to want the comment to be not part of the name. Which is the case. So I think it's ok to merge this patch. If you have any doubts at all I'm ready to drop this, too. It's nice to have comments after commands, but not really that important either. -- To view, visit https://gerrit.osmocom.org/3882 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccd9cc8604494379910c534b35ce7e74e329d863 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: No