osmo-gsm-tester[master]: Use own format to specify encryption algorithm

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sat Sep 9 00:33:05 UTC 2017


Patch Set 1:

> I must admit I hated you a bit while reworking this to use "_" instead of " " :-P

Yes, I deserve it in this instance.

But we have uncovered a boundary of the current implementation, hopefully we can recall this before we run into similar issues. I'd have liked us to fix this in a generalized manner to help avoid this entire class of problem in the future, but I agree that it would be a very large scratch for a currently very small itch.

Actually, if we kept the 'a5' part out of the value, we wouldn't have the problem in this instance; we'd just store and render plain integers. I'm not aware of an alternative to 'a5', the vty command 'encryption' only ever has 'a5' and nothing else so far.

Consider this and if you will +2 yourself to merge.

-- 
To view, visit https://gerrit.osmocom.org/3815
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5265cc9990dd5e99dba1f6262b3a8c597a3e958d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list