osmo-bts[master]: Check readv() return value to prevent crash

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Sep 8 12:19:13 UTC 2017


Patch Set 5: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/3878/5/src/osmo-bts-litecell15/l1_transp_hw.c
File src/osmo-bts-litecell15/l1_transp_hw.c:

Line 212: 		   TODO: use libexplain's explain_readv() to provide detailed error description */
I don't think we need to add another dep just to know this kind of things. If there's an error, read the manual and read the code of glibc + syscall.


-- 
To view, visit https://gerrit.osmocom.org/3878
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I956c8d551f45c9dd43b5e9de11dfe20dd8783647
Gerrit-PatchSet: 5
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list