osmo-bts[master]: Check return value to prevent crash

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Wed Sep 6 15:47:03 UTC 2017


Patch Set 3: Code-Review-1

(2 comments)

Your assignment of count has no effect

Maybe use if/else?

https://gerrit.osmocom.org/#/c/3878/3/src/osmo-bts-litecell15/l1_transp_hw.c
File src/osmo-bts-litecell15/l1_transp_hw.c:

Line 211: 	count = rc / prim_size;
same


https://gerrit.osmocom.org/#/c/3878/3/src/osmo-bts-sysmo/l1_transp_hw.c
File src/osmo-bts-sysmo/l1_transp_hw.c:

Line 222: 	count = rc / prim_size;
count will be overwritten here...


-- 
To view, visit https://gerrit.osmocom.org/3878
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I956c8d551f45c9dd43b5e9de11dfe20dd8783647
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list