osmo-gsm-tester[master]: resource: Fix list comparison in item_matches

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Sep 4 12:29:03 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/3721/1/src/osmo_gsm_tester/resource.py
File src/osmo_gsm_tester/resource.py:

Line 449:                 return False
> I'll provide a test for this. I think I stumbled onto it when trying to use
After doing some tests, it fixes the following scenario:
You have a BTS which supports a50 and a51. Then you use only 1 of the ciphers in the scenario, for instance a50. Without this patch, this setup will fail.

I'll push a new version of the commit with better git commit description.

A test in test_resources.py is already provided with later commits when cipher attribute is added, which checks for this case. So, in later commits, if this commit is not present  then "make check" fails, I just tried it:

--- /home/pespin/dev/sysmocom/git/osmo-gsm-tester-sysmocom/osmo-gsm-tester/selftest/resource_test.err
+++ got
@@ -0,0 +1,8 @@
+Traceback (most recent call last):
+  File "/home/pespin/dev/sysmocom/git/osmo-gsm-tester-sysmocom/osmo-gsm-tester/selftest/resource_test.py", line 83, in <module>
+    resources = pool.reserve(origin, want)
+  File "/home/pespin/dev/sysmocom/git/osmo-gsm-tester-sysmocom/osmo-gsm-tester/selftest/../src/osmo_gsm_tester/resource.py", line 155, in reserve
+    to_be_reserved = self.all_resources.without(reserved).find(origin, want)
+  File "/home/pespin/dev/sysmocom/git/osmo-gsm-tester-sysmocom/osmo-gsm-tester/selftest/../src/osmo_gsm_tester/resource.py", line 332, in find
+    % (key, want_item))
+osmo_gsm_tester.resource.NoResourceExn: No matching resource available for bts = {'type': 'osmo-bts-sysmo', 'ciphers': ['a5 1']}
output mismatch: 'resource_test.err'

Test failed: 'resource_test.py'


-- 
To view, visit https://gerrit.osmocom.org/3721
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27b372aa5906feac2843f24f5cdd0d9578d44b4d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list