osmo-pcu[master]: cosmetic: convert explicit warnings to fixme/todo

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Mon Sep 4 11:28:47 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/3761/1/src/gprs_bssgp_pcu.cpp
File src/gprs_bssgp_pcu.cpp:

Line 969: 	talloc_free(the_pcu.bctx);
> what? do we have a missing free here? Why can we just omit it, because we n
Yes to both questions.


-- 
To view, visit https://gerrit.osmocom.org/3761
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72070e2a027e60e8b80c12ccfa23ff075434689f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list