osmo-gsm-tester[master]: Add cipher cfg param for modem and bts

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Sep 4 10:03:42 UTC 2017


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/3723/3/example/resources.conf
File example/resources.conf:

Line 16:   ciphers: ['a5 0', 'a5 1', 'a5 3']
> re-reading this, I get two thoughts:
TBH, I don't care that much.
I think it's still nice to use the quoting because as far as I remember you told you have issues without quoting. Because a50 can be understood as a hex number right? In any case, quoting also helps me understand that this value is being used a string in the code.

So, in summary, I can indeed move those to a5_0 or a50, but I'll keep the quoting are it's still string keywords being used, like "xor" or "foobar".


-- 
To view, visit https://gerrit.osmocom.org/3723
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e368843a6e58bd3eeef36d2c0a7501296f0f3e
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list