osmo-sip-connector[master]: sdp.c Send octet-align in fmtp

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Sun Sep 3 18:35:32 UTC 2017


Patch Set 11:

(2 comments)

Could you test my version?

https://gerrit.osmocom.org/#/c/3735/10/src/sdp.c
File src/sdp.c:

Line 169: 	char *fmtp_str = NULL, *sdp;
We would need to allocate this with memory as well or have a NULL check.


Line 173: 	if (strcmp(leg->wanted_codec, "AMR") == 0)
I would prefer strcmp(leg->wanted_codec, "AMR") == 0


-- 
To view, visit https://gerrit.osmocom.org/3735
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I938758ac4ec55db9223e3da6c3c277e8fa670055
Gerrit-PatchSet: 11
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list