osmo-ci[master]: jenkins: Follow the convention and create a jenkins.sh as well

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sat Sep 2 18:29:06 UTC 2017


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/3676/1/contrib/jenkins.sh
File contrib/jenkins.sh:

Line 3: cd ~/osmo-ci || (cd ~/ && git clone git://git.osmocom.org/osmo-ci)
nice, but in the clone case it is missing a final 'cd osmo-ci'


Line 7: git pull origin
I've had massive pains with "git, please just use latest master", and it looks like this could fall in the trap and remain on a revision without us noticing, e.g. if 'master' was ever force-updated, or if for some reason there are conflicts with local files... The easiest is indeed to clone afresh each and every time, otherwise it seems to me we need to go for things like

  rm -rf ./*
  git reset --hard origin/master

Not sure what's the optimal way there; for the osmo-gsm-tester where I want to use either branch name or git hash, I went for both re-cloning and checking out a build branch :P https://git.osmocom.org/osmo-gsm-tester/tree/contrib/jenkins-build-common.sh#n75


-- 
To view, visit https://gerrit.osmocom.org/3676
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ecdc02e3271fe09980f370167277370c599fcfa
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list