libosmocore[master]: lapd_core: Fix crash in lapd_est_req() function

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Ivan Kluchnikov gerrit-no-reply at lists.osmocom.org
Fri Sep 1 13:28:28 UTC 2017


Patch Set 1:

Hello Harald,
Sorry for slow response, I don't think this fix overlaps with gerrit 266 and 3257.
Regrading the unittest - unfortunately my understanding of the code is not enough to implement a meaningful unittest.
If unittest is a requirement, I need to find some time to learn the code more deeply which I'm afraid won't happen soon.
Or may be I don't understand what test do you mean?
I assume you are talking about a test case for statefull handling for DL SAP messages from L3 which is implemented in lapd_recv_dlsap() function.

-- 
To view, visit https://gerrit.osmocom.org/3467
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I306dad9b78e3becaef14c5305ec25c312feefe3c
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Ivan Kluchnikov <kluchnikovi at gmail.com>
Gerrit-Reviewer: Alexander Chemeris <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Ivan Kluchnikov <kluchnikovi at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No



More information about the gerrit-log mailing list