This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Patch Set 2: Code-Review+1
(2 comments)
https://gerrit.osmocom.org/#/c/3753/2/src/pcu_l1_if.cpp
File src/pcu_l1_if.cpp:
Line 166: #ifdef ENABLE_DIRECT_PHY
unrelated cosmetic change?
Line 252: if (len != GSM_MACBLOCK_LEN) {
might be a good idea to use len==0 to set si13_is_set to false.
--
To view, visit https://gerrit.osmocom.org/3753
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I610a93ce23725b182ec14e3507331295bd542f74
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes