[MERGED] osmo-hlr[master]: db_test: fix *FLAGS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Oct 28 16:49:34 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: db_test: fix *FLAGS
......................................................................


db_test: fix *FLAGS

The -I includes should be in CFLAGS, not CPPFLAGS.

I noticed problems with it when trying to add an -I$(builddir) in an upcoming
patch that adds a BUILT_SOURCE, If77dbbfe1af3e66aaec91cb6295b687f37678636.

Change-Id: Ie57a04b7efc7a1e16cf0e3625d8ad2f0ef0089b0
---
M tests/db/Makefile.am
1 file changed, 1 insertion(+), 7 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/db/Makefile.am b/tests/db/Makefile.am
index a1f35a7..b706bec 100644
--- a/tests/db/Makefile.am
+++ b/tests/db/Makefile.am
@@ -1,17 +1,11 @@
-AM_CPPFLAGS = \
+AM_CFLAGS = \
 	$(all_includes) \
 	-I$(top_srcdir)/src \
-	$(NULL)
-
-AM_CFLAGS = \
 	-Wall \
 	-ggdb3 \
 	$(LIBOSMOCORE_CFLAGS) \
 	$(LIBOSMOGSM_CFLAGS) \
 	$(SQLITE3_CFLAGS) \
-	$(NULL)
-
-AM_LDFLAGS = \
 	$(NULL)
 
 EXTRA_DIST = \

-- 
To view, visit https://gerrit.osmocom.org/4437
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie57a04b7efc7a1e16cf0e3625d8ad2f0ef0089b0
Gerrit-PatchSet: 2
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list