This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: cosmetic: sql/hlr.sql: move comments ...................................................................... cosmetic: sql/hlr.sql: move comments By moving the comments inside the table row definitions, they are dumped back during 'sqlite3 hlr.db .dump'. When they are between SQL statements like before this patch, the comments are lost. Tweak wording. Change-Id: I280c2e2d3e9b7f1dc632722724d9e1c54d041820 --- M sql/hlr.sql 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/sql/hlr.sql b/sql/hlr.sql index 696cf1c..80eb3e5 100644 --- a/sql/hlr.sql +++ b/sql/hlr.sql @@ -1,6 +1,5 @@ ---modelled roughly after TS 23.008 version 13.3.0 - CREATE TABLE IF NOT EXISTS subscriber ( +-- OsmoHLR's DB scheme is modelled roughly after TS 23.008 version 13.3.0 id INTEGER PRIMARY KEY, -- Chapter 2.1.1.1 imsi VARCHAR(15) UNIQUE NOT NULL, @@ -45,8 +44,8 @@ apn VARCHAR(256) NOT NULL ); --- Chapter 2.1.3 CREATE TABLE IF NOT EXISTS subscriber_multi_msisdn ( +-- Chapter 2.1.3 subscriber_id INTEGER, -- subscriber.id msisdn VARCHAR(15) NOT NULL ); -- To view, visit https://gerrit.osmocom.org/4439 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I280c2e2d3e9b7f1dc632722724d9e1c54d041820 Gerrit-PatchSet: 2 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder