This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Review at https://gerrit.osmocom.org/4405
Fix Downlink AMR FSM name to avoid illegal space character
Since libosmocore Change-Id I9ef59432f43a3cdb94e4cbb0c44ac3f9b2aac0f2
we enforce that FSM names do not contain illegal characteers such as
spaces. Let's change the DL TX FSM for AMR to comply to this. Also,
actually do check the result of the FSM registration.
Change-Id: Ieccd1dc32c0faf5e544d17daca4a417d1d168c21
---
M src/common/bts.c
M src/common/dtx_dl_amr_fsm.c
2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/05/4405/1
diff --git a/src/common/bts.c b/src/common/bts.c
index cb5284d..6747f50 100644
--- a/src/common/bts.c
+++ b/src/common/bts.c
@@ -180,7 +180,9 @@
INIT_LLIST_HEAD(&btsb->oml_queue);
/* register DTX DL FSM */
- osmo_fsm_register(&dtx_dl_amr_fsm);
+ rc = osmo_fsm_register(&dtx_dl_amr_fsm);
+ OSMO_ASSERT(rc == 0);
+
return rc;
}
diff --git a/src/common/dtx_dl_amr_fsm.c b/src/common/dtx_dl_amr_fsm.c
index d599048..38e22c9 100644
--- a/src/common/dtx_dl_amr_fsm.c
+++ b/src/common/dtx_dl_amr_fsm.c
@@ -469,7 +469,7 @@
};
struct osmo_fsm dtx_dl_amr_fsm = {
- .name = "DTX DL AMR FSM",
+ .name = "DTX_DL_AMR_FSM",
.states = dtx_dl_amr_fsm_states,
.num_states = ARRAY_SIZE(dtx_dl_amr_fsm_states),
.event_names = dtx_dl_amr_fsm_event_names,
--
To view, visit https://gerrit.osmocom.org/4405
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieccd1dc32c0faf5e544d17daca4a417d1d168c21
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>