This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgPatch Set 6: Code-Review-1 (3 comments) https://gerrit.osmocom.org/#/c/4311/6/src/ctrl.c File src/ctrl.c: Line 233: aud3g.algo = OSMO_AUTH_ALG_NONE; I'm confused by this part. In case of ENOENT error we will continue with printing auth data to resp. but other errors will result in failure. If that's indeed the intention than it's worth placing a comment here which explains what's so special about ENOENT. Usually all the errors result in the same behavior. Line 258: rc = db_get_auth_data(hlr->dbc, subscr.imsi, &aud2g, &aud3g, NULL); If someone later have to change db-get_auth_data() they got to make sure not to break this special ENOENT case. Maybe place a comment in there? Line 262: aud3g.algo = OSMO_AUTH_ALG_NONE; Same here. Maybe move it to separate inline function? -- To view, visit https://gerrit.osmocom.org/4311 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98ee6a06b3aa6a67adb868e0b63b0e04eb42eb50 Gerrit-PatchSet: 6 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes