osmo-mgw[master]: mgcp: move port/timeslot calculator to mgcp_common.h

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Oct 23 13:49:39 UTC 2017


Patch Set 6:

> No, the new MGW does not make use of these functions.

Anything that's not used by the new osmo-mgw shouldn't be part of libosmo-mgcp. Either remain in libosmo-legacy-mgcp if only used by old programs, or, if they are still used/going to be used by other binaries after they moved to the new libosmo-sigtran, they can go into libosmo-mgcp-client.

But I hope I'm not missing anything, particularly, I haven't wrapped my head around the future of osmo-bsc_nat or whether/how we will replace osmo-bsc_mgcp.

Anyway, it seems good to keep legacy ways in the legacy library as much as possible; anything using the new libosmo-mgcp should use the port numbers returned upon CRCX, right? Hence we need no magic port calculation for libosmo-mgcp and neither for libosmo-mgcp-client?

How did this patch come about? For which caller?

-- 
To view, visit https://gerrit.osmocom.org/4237
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a553e863701d3bafa7b8dc17a503455c303546e
Gerrit-PatchSet: 6
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list