osmo-bts[master]: vty: Use new API abis_nm_admin_name

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Oct 23 01:25:18 UTC 2017


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/4358/1/src/common/vty.c
File src/common/vty.c:

Line 716: 		abis_nm_admin_name(nms->administrative),
this is a good improvement, write the meaningful name instead of the "arbitrary" enum number. If that other patch isn't merged, let's do it with get_value_string() instead.


-- 
To view, visit https://gerrit.osmocom.org/4358
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie41479958d6a57708e4b50705fd85c65f02e4527
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list