libosmocore[master]: Expand bitvec_write_field()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Oct 23 01:05:45 UTC 2017


Patch Set 4: Code-Review+1

(2 comments)

(apologies if I'm asking stupid questions, am not so familiar with this part of the code)

https://gerrit.osmocom.org/#/c/4292/4/include/osmocom/core/bitvec.h
File include/osmocom/core/bitvec.h:

Line 75: int bitvec_write_field_ext(struct bitvec *bv, uint32_t *write_index, uint64_t val, uint8_t len, bool use_lh);
can the caller use the new bitvec_set_u64() instead?


https://gerrit.osmocom.org/#/c/4292/4/tests/bits/bitfield_test.ok
File tests/bits/bitfield_test.ok:

Line 12: === total 1 bits differ ===
is this ok??


-- 
To view, visit https://gerrit.osmocom.org/4292
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee648d764de9f3e7ef850f40864ad701c83f61db
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list