[PATCH] python/osmo-python-tests[master]: cosmetic: cmdline arg doc tweaks, comment

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Oct 18 01:57:49 UTC 2017


Review at  https://gerrit.osmocom.org/4325

cosmetic: cmdline arg doc tweaks, comment

Change-Id: I60dc059879dfe15cd3415ce1ed068ded28ff084e
---
M osmopy/osmo_interact_common.py
M osmopy/osmo_interact_vty.py
2 files changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/python/osmo-python-tests refs/changes/25/4325/1

diff --git a/osmopy/osmo_interact_common.py b/osmopy/osmo_interact_common.py
index 6107b64..57f00bf 100644
--- a/osmopy/osmo_interact_common.py
+++ b/osmopy/osmo_interact_common.py
@@ -349,15 +349,15 @@
                         ' including command line arguments. If omitted, no'
                         ' application is launched.')
     parser.add_argument('-p', '--port', dest='port',
-                        help="Port that the application opens.")
+                        help="Port to reach the application at.")
     parser.add_argument('-H', '--host', dest='host', default='localhost',
-                        help="Host that the application opens the port on.")
+                        help="Host to reach the application at.")
     return parser
 
 def parser_add_verify_args(parser):
     parser.add_argument('-u', '--update', dest='update', action='store_true',
                         help='Do not verify, but OVERWRITE transcripts based on'
-                        ' the applications current behavior. OVERWRITES TRANSCRIPT'
+                        ' the application\'s current behavior. OVERWRITES TRANSCRIPT'
                         ' FILES.')
     parser.add_argument('-v', '--verbose', action='store_true',
                         help='Print commands and application output')
diff --git a/osmopy/osmo_interact_vty.py b/osmopy/osmo_interact_vty.py
index c484932..b57cd8c 100755
--- a/osmopy/osmo_interact_vty.py
+++ b/osmopy/osmo_interact_vty.py
@@ -142,6 +142,7 @@
 
         received_lines = self._command(command_str, timeout)
 
+        # send escape to cancel the '?' command line
         if command_str[-1] == '?':
             self._command('\x03', timeout)
 

-- 
To view, visit https://gerrit.osmocom.org/4325
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I60dc059879dfe15cd3415ce1ed068ded28ff084e
Gerrit-PatchSet: 1
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list