This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgHello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4238 to look at the new patch set (#5). mgcp: move misplaced include mgcp.h includes mgcp_ep.h but does not use anything from it. This does not hurt the mgcp code internally, but when mgcp.h is included by an application compilation fails because mgcp_ep.h is not installed. remove mgcp_ep.h from include list in mgcp.h add mgcp_ep.h to include list in mgcp_conn.c where it is needed. Change-Id: Ib58a8ed64f729055282c2b9673f7684cdfdb5936 --- M include/osmocom/mgcp/mgcp.h M src/libosmo-mgcp/mgcp_conn.c 2 files changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/38/4238/5 diff --git a/include/osmocom/mgcp/mgcp.h b/include/osmocom/mgcp/mgcp.h index 07d9516..7307f3c 100644 --- a/include/osmocom/mgcp/mgcp.h +++ b/include/osmocom/mgcp/mgcp.h @@ -26,7 +26,6 @@ #include <osmocom/core/write_queue.h> #include <osmocom/core/timer.h> #include <osmocom/core/logging.h> -#include <osmocom/mgcp/mgcp_ep.h> #include <osmocom/mgcp/mgcp_common.h> diff --git a/src/libosmo-mgcp/mgcp_conn.c b/src/libosmo-mgcp/mgcp_conn.c index 0da62bc..e0eec63 100644 --- a/src/libosmo-mgcp/mgcp_conn.c +++ b/src/libosmo-mgcp/mgcp_conn.c @@ -24,6 +24,7 @@ #include <osmocom/mgcp/mgcp_conn.h> #include <osmocom/mgcp/mgcp_internal.h> #include <osmocom/mgcp/mgcp_common.h> +#include <osmocom/mgcp/mgcp_ep.h> /* Reset codec state and free memory */ static void mgcp_rtp_codec_reset(struct mgcp_rtp_codec *codec) -- To view, visit https://gerrit.osmocom.org/4238 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib58a8ed64f729055282c2b9673f7684cdfdb5936 Gerrit-PatchSet: 5 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>