osmo-gsm-tester[master]: modem: Implement voice calls in modem and add voice suite

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Oct 13 14:25:08 UTC 2017


Patch Set 1:

(5 comments)

https://gerrit.osmocom.org/#/c/4150/1/src/osmo_gsm_tester/ofono_client.py
File src/osmo_gsm_tester/ofono_client.py:

Line 594:         call_dbus_obj = systembus_get(call_id)
> I guess it will throw an exception. I wouldn't invest time in this until we
ok then


Line 601:         call_dbus_obj = systembus_get(call_id)
> I could add a "call_exists(call_id) which basically does systembus_get(call
indeed, waiting for a NoneTypeException to happen is easier for now


https://gerrit.osmocom.org/#/c/4150/1/suites/voice/mo_mt_call.py
File suites/voice/mo_mt_call.py:

Line 35: wait(msc.subscriber_attached, ms_mo, ms_mt)
> I think we should have some kind of test-side library of function for steps
like a from osmo_gsm_tester.common import bootstrap_net


Line 40: mt_call_id = ms_mt.call_id_list()[0]
> AFAIR the VoiceCall interface has the number of the other endpoint in its p
semantically I would welcome the ability to wait for a specific subscriber to call, so I think ms_mt.call_wait_incoming(ms_or_msisdn) would be worthwhile, yes


Line 53: wait(lambda: len(ms_mo.call_id_list()) == 0 and len(ms_mt.call_id_list()) == 0)
> You cannot do that because it may take a while (delay) for the other ms to 
I mean, just make sure that before we start doing anything with voice calls way above, verify that the call_id_list() is empty as expected. Simply because here we assume that ending the call brings us back to an empty list.


-- 
To view, visit https://gerrit.osmocom.org/4150
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib402effc830db293f27a877658894e454a93a606
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list