This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.org
Patch Set 2:
(2 comments)
> tests/alloc/AllocTest.cpp requires updates to use/test the new classes as well.
^^^ Is this addressed?
https://gerrit.osmocom.org/#/c/4072/2//COMMIT_MSG
Commit Message:
Line 15: yet - this can be extended once we have such devices to test it.
How would you support it? Shall we print a runtime warning once this class is being used?
https://gerrit.osmocom.org/#/c/4072/2/src/gprs_rlcmac_ts_alloc.cpp
File src/gprs_rlcmac_ts_alloc.cpp:
Line 531: if (ms->ms_class() >= ARRAY_SIZE(gprs_ms_multislot_class)) {
I would have avoided the extra reformatting.
--
To view, visit https://gerrit.osmocom.org/4072
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef2eb99c517f25e7d1e71b985a3e0eb3879eb2c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes