This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgPatch Set 2: Code-Review-1 (2 comments) Please clarify further. https://gerrit.osmocom.org/#/c/4200/2/tests/msgb/msgb_test.c File tests/msgb/msgb_test.c: Line 296: Please add more test-cases: for example "msgb_printf(msg, "", 23, 0xfee, "text");" and "msgb_printf(msg, "%d %s %c", "lol", 0xfeed, "text", "oops");" do not look very legit. How does msgb_printf() behaves in this case? Not exactly those 2 examples but something which highlights corner-cases. https://gerrit.osmocom.org/#/c/4200/2/tests/msgb/msgb_test.ok File tests/msgb/msgb_test.ok: Line 37: rc=-22, total_len=79, msg->data=|this is a test 4711, testme, 4711||some more text||more 23 fee tex So despite the error, msgb have changed? If that's the desired behavior than it should be clearly documented. -- To view, visit https://gerrit.osmocom.org/4200 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15e1af68616309555d0ed9ac5da027c9833d42e3 Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-HasComments: Yes