This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/4175 cosmetic: don't log about missing SQLite log cb SQLite3 seems to be commonly compiled without log callback support. It is then misleading to see a seeming error message about this on each osmo-hlr startup. Avoid the impression that we would miss out on important logging: simply ignore any errors upon registering the log callback. We do receive logging on each DB error. Change-Id: I78d75dc351eb587b0a022f82f147e9a31c0324c5 --- M src/db.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/75/4175/1 diff --git a/src/db.c b/src/db.c index 2c10ba0..3e64e7d 100644 --- a/src/db.c +++ b/src/db.c @@ -139,9 +139,9 @@ if (rc != SQLITE_OK) LOGP(DDB, LOGL_NOTICE, "Unable to set SQlite3 error log callback\n"); - rc = sqlite3_config(SQLITE_CONFIG_SQLLOG, sql3_sql_log_cb, NULL); - if (rc != SQLITE_OK) - LOGP(DDB, LOGL_NOTICE, "Unable to set SQlite3 SQL statement log callback\n"); + /* SQLite may be compiled without log callback support, don't complain + * about errors here. */ + sqlite3_config(SQLITE_CONFIG_SQLLOG, sql3_sql_log_cb, NULL); rc = sqlite3_open(dbc->fname, &dbc->db); if (rc != SQLITE_OK) { -- To view, visit https://gerrit.osmocom.org/4175 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I78d75dc351eb587b0a022f82f147e9a31c0324c5 Gerrit-PatchSet: 1 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>