libosmocore[master]: gsm: make osmo_imsi_str_valid() NULL-safe

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sun Oct 8 20:04:12 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/4156/1/src/gsm/gsm23003.c
File src/gsm/gsm23003.c:

Line 36: 	for (len = 0; pos && *pos && len < max_digits; len++, pos++)
> a NULL str may still return true when min_digits == 0. Ah, this reminds me 
ah, nonsense, the osmo_{msisdn,imsi}_valid never call it with min_digits <= 0. If is_n_digits() were available to more users, the current patch would make sense. As it is now you are probably right to complain. It came to be this way because I copied from G#4159 without considering that this one is static and we know all the callers.


-- 
To view, visit https://gerrit.osmocom.org/4156
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I111fbf29228929f2cd6ffa06bcb1f69da223224e
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list