[MERGED] osmo-msc[master]: add ';' after OSMO_ASSERT()

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged.

Change subject: add ';' after OSMO_ASSERT()
......................................................................


add ';' after OSMO_ASSERT()

Currently, OSMO_ASSERT() is defined such that it ends in a semicolon, hence an
added ';' is redundant. However, the usual way this kind of macro should be
defined is

  #define OSMO_ASSERT(x) do { ... } while(0)

so that the compiler requires a trailing semicolon.

To prepare for such a change possibly coming up in libosmocore, add ';' to all
OSMO_ASSERT() users.

Change-Id: Ic79c8b8f98a7f3bef761751d55a7e6125cf2c46d
---
M src/libmsc/gsm_04_08.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c
index 84f52c6..8a5265b 100644
--- a/src/libmsc/gsm_04_08.c
+++ b/src/libmsc/gsm_04_08.c
@@ -3220,7 +3220,7 @@
 	uint8_t pdisc;
 	int rc = 0;
 
-	OSMO_ASSERT(msg->l3h)
+	OSMO_ASSERT(msg->l3h);
 	OSMO_ASSERT(conn);
 	OSMO_ASSERT(msg);
 

-- 
To view, visit https://gerrit.osmocom.org/4143
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic79c8b8f98a7f3bef761751d55a7e6125cf2c46d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>