osmo-mgw[master]: client: add ip address parsing to the client

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Oct 6 00:49:25 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/4147/1/include/osmocom/mgcp_client/mgcp_client.h
File include/osmocom/mgcp_client/mgcp_client.h:

Line 39: 	uint32_t audio_ip;
I think for years in most places in osmocom code, we started to represent IP addresses as "char *host" instead, in order to not introduce further IPv6 incompatibilities.  So even if the current parser can only deal with parsing an IPv4 address in the MGCP messsage, the library APIs (and hence applications) could already be written independent of the specific address family.


-- 
To view, visit https://gerrit.osmocom.org/4147
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44b338b09de45e1675cedf9737fa72dde72e979a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list