osmocom-bb[master]: mobile: Begin with a primitive interface on top of the code

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Nov 30 21:29:16 UTC 2017


Patch Set 7: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/#/c/4771/7//COMMIT_MSG
Commit Message:

Line 10: interface. This will allow to move it to a different thread or
I think you should mention that it is an interface.

;) ;)


https://gerrit.osmocom.org/#/c/4771/7/src/host/layer23/src/mobile/primitives.c
File src/host/layer23/src/mobile/primitives.c:

Line 39: 	intf->ms = ms;
depends on the usage, but ... if the osmocom_ms gets freed, should there be a safeguard to tear down / invalidate the prim_intf->ms as well?


Line 101: 
(ws)


-- 
To view, visit https://gerrit.osmocom.org/4771
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2456b7fae35546553c4805f12a40c0812d9255c
Gerrit-PatchSet: 7
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list