[PATCH] osmocom-bb[master]: mobile: Speculative crash fix of the SI pointer

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Thu Nov 30 18:03:46 UTC 2017


Review at  https://gerrit.osmocom.org/5112

mobile: Speculative crash fix of the SI pointer

The SIs are kept per ARFCN and for the current cell the
cs->si alias will be assigned[1]. On mobile_exit all SIs
will be freed but the alias will not be set to NULL.

This is a speculative fix but it doesn't seem to make
things worse.

Related: OS#2690

[1] cs->si = cs->list[cs->arfci].sysinfo;

Change-Id: Icf20f9aa03dd26d4bee78772b7f3da034bb34b99
---
M src/host/layer23/src/mobile/gsm322.c
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/12/5112/1

diff --git a/src/host/layer23/src/mobile/gsm322.c b/src/host/layer23/src/mobile/gsm322.c
index 6de8bec..c3485b6 100644
--- a/src/host/layer23/src/mobile/gsm322.c
+++ b/src/host/layer23/src/mobile/gsm322.c
@@ -5141,6 +5141,7 @@
 		}
 		cs->list[i].flags = 0;
 	}
+	cs->si = NULL;
 
 	/* store BA list */
 	ba_filename = talloc_asprintf(ms, "%s/%s.ba", config_dir, ms->name);

-- 
To view, visit https://gerrit.osmocom.org/5112
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf20f9aa03dd26d4bee78772b7f3da034bb34b99
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther <holger at freyther.de>



More information about the gerrit-log mailing list