This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has submitted this change and it was merged. Change subject: sccp-lite: remove obsolete VTY commands ...................................................................... sccp-lite: remove obsolete VTY commands remove obsolete vty commands: - token - auth-key - no auth-key Change-Id: I9101d750a424b8af46d603bc7c877229bbae8727 --- M include/osmocom/bsc/bsc_msc_data.h M src/osmo-bsc/osmo_bsc_vty.c 2 files changed, 0 insertions(+), 47 deletions(-) Approvals: Neels Hofmeyr: Looks good to me, approved Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/bsc/bsc_msc_data.h b/include/osmocom/bsc/bsc_msc_data.h index 4a283d1..a3e0106 100644 --- a/include/osmocom/bsc/bsc_msc_data.h +++ b/include/osmocom/bsc/bsc_msc_data.h @@ -72,10 +72,6 @@ /* Connection data */ - char *bsc_token; - uint8_t bsc_key[16]; - uint8_t bsc_key_present; - int ping_timeout; int pong_timeout; struct osmo_timer_list ping_timer; diff --git a/src/osmo-bsc/osmo_bsc_vty.c b/src/osmo-bsc/osmo_bsc_vty.c index 0003cfa..a87b20f 100644 --- a/src/osmo-bsc/osmo_bsc_vty.c +++ b/src/osmo-bsc/osmo_bsc_vty.c @@ -108,11 +108,6 @@ struct bsc_msc_dest *dest; vty_out(vty, "msc %d%s", msc->nr, VTY_NEWLINE); - if (msc->bsc_token) - vty_out(vty, " token %s%s", msc->bsc_token, VTY_NEWLINE); - if (msc->bsc_key_present) - vty_out(vty, " auth-key %s%s", - osmo_hexdump(msc->bsc_key, sizeof(msc->bsc_key)), VTY_NEWLINE); if (msc->core_mnc != -1) vty_out(vty, " core-mobile-network-code %d%s", msc->core_mnc, VTY_NEWLINE); @@ -233,41 +228,6 @@ if (bsc->acc_lst_name) vty_out(vty, " access-list-name %s%s", bsc->acc_lst_name, VTY_NEWLINE); - return CMD_SUCCESS; -} - -DEFUN(cfg_net_bsc_token, - cfg_net_bsc_token_cmd, - "token TOKEN", - "A token for the BSC to be sent to the MSC\n" "A token\n") -{ - struct bsc_msc_data *data = bsc_msc_data(vty); - - osmo_talloc_replace_string(osmo_bsc_data(vty), &data->bsc_token, argv[0]); - return CMD_SUCCESS; -} - -DEFUN(cfg_net_bsc_key, - cfg_net_bsc_key_cmd, - "auth-key KEY", - "Authentication (secret) key configuration\n" - "Security key\n") -{ - struct bsc_msc_data *data = bsc_msc_data(vty); - - osmo_hexparse(argv[0], data->bsc_key, sizeof(data->bsc_key)); - data->bsc_key_present = 1; - return CMD_SUCCESS; -} - -DEFUN(cfg_net_no_bsc_key, cfg_net_bsc_no_key_cmd, - "no auth-key", - NO_STR "Authentication (secret) key configuration\n") -{ - struct bsc_msc_data *data = bsc_msc_data(vty); - - memset(data->bsc_key, 0, sizeof(data->bsc_key)); - data->bsc_key_present = 0; return CMD_SUCCESS; } @@ -989,9 +949,6 @@ install_element(BSC_NODE, &cfg_bsc_no_acc_lst_name_cmd); install_node(&msc_node, config_write_msc); - install_element(MSC_NODE, &cfg_net_bsc_token_cmd); - install_element(MSC_NODE, &cfg_net_bsc_key_cmd); - install_element(MSC_NODE, &cfg_net_bsc_no_key_cmd); install_element(MSC_NODE, &cfg_net_bsc_ncc_cmd); install_element(MSC_NODE, &cfg_net_bsc_mcc_cmd); install_element(MSC_NODE, &cfg_net_bsc_lac_cmd); -- To view, visit https://gerrit.osmocom.org/5094 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9101d750a424b8af46d603bc7c877229bbae8727 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: dexter <pmaier at sysmocom.de>