This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 7: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/4905/7/src/libosmo-mgcp/mgcp_conn.c File src/libosmo-mgcp/mgcp_conn.c: Line 63: LOGP(DLMGCP, LOGL_ERROR, "endpoint:%x, unable to generate a unique connectionIdentifier\n", I think it's 0x prefixed in other patches now? https://gerrit.osmocom.org/#/c/4905/7/tests/mgcp/mgcp_test.c File tests/mgcp/mgcp_test.c: Line 579: OSMO_ASSERT(strlen(conn_id) <= 32); so we receive a response from another network element, which is UDP based and can be spoofed by anyone, and we crash our MGW based on this? "ASSERT" should be used in cases where something has gone wrong so badly that assumptions of the developer have not been fulfilled. Under no circumstances we should ASSERT on any message received from a remote entity on the network. -- To view, visit https://gerrit.osmocom.org/4905 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab6a6038e7610c62f34e642cd49c93d11151252c Gerrit-PatchSet: 7 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-HasComments: Yes