[MERGED] osmo-sgsn[master]: Replace '.' in counter names with ':'

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Nov 29 11:55:31 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: Replace '.' in counter names with ':'
......................................................................


Replace '.' in counter names with ':'

'.' is an illegal character in counter names, as they are exported
via CTRL interface, where '.' has a special meaning that cannot be
used by strings comprising the variable name.

Change-Id: Ie7734cc42151581897d220b445984448ceb57aed
---
M src/gprs/gprs_sgsn.c
1 file changed, 14 insertions(+), 14 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gprs/gprs_sgsn.c b/src/gprs/gprs_sgsn.c
index 5eff404..768d953 100644
--- a/src/gprs/gprs_sgsn.c
+++ b/src/gprs/gprs_sgsn.c
@@ -65,21 +65,21 @@
 LLIST_HEAD(sgsn_pdp_ctxts);
 
 static const struct rate_ctr_desc mmctx_ctr_description[] = {
-	{ "sign.packets.in",	"Signalling Messages ( In)" },
-	{ "sign.packets.out",	"Signalling Messages (Out)" },
-	{ "udata.packets.in",	"User Data  Messages ( In)" },
-	{ "udata.packets.out",	"User Data  Messages (Out)" },
-	{ "udata.bytes.in",	"User Data  Bytes    ( In)" },
-	{ "udata.bytes.out",	"User Data  Bytes    (Out)" },
+	{ "sign:packets:in",	"Signalling Messages ( In)" },
+	{ "sign:packets:out",	"Signalling Messages (Out)" },
+	{ "udata:packets:in",	"User Data  Messages ( In)" },
+	{ "udata:packets:out",	"User Data  Messages (Out)" },
+	{ "udata:bytes:in",	"User Data  Bytes    ( In)" },
+	{ "udata:bytes:out",	"User Data  Bytes    (Out)" },
 	{ "pdp_ctx_act",	"PDP Context Activations  " },
 	{ "suspend",		"SUSPEND Count            " },
-	{ "paging.ps",		"Paging Packet Switched   " },
-	{ "paging.cs",		"Paging Circuit Switched  " },
+	{ "paging:ps",		"Paging Packet Switched   " },
+	{ "paging:cs",		"Paging Circuit Switched  " },
 	{ "ra_update",		"Routing Area Update      " },
 };
 
 static const struct rate_ctr_group_desc mmctx_ctrg_desc = {
-	.group_name_prefix = "sgsn.mmctx",
+	.group_name_prefix = "sgsn:mmctx",
 	.group_description = "SGSN MM Context Statistics",
 	.num_ctr = ARRAY_SIZE(mmctx_ctr_description),
 	.ctr_desc = mmctx_ctr_description,
@@ -87,14 +87,14 @@
 };
 
 static const struct rate_ctr_desc pdpctx_ctr_description[] = {
-	{ "udata.packets.in",	"User Data  Messages ( In)" },
-	{ "udata.packets.out",	"User Data  Messages (Out)" },
-	{ "udata.bytes.in",	"User Data  Bytes    ( In)" },
-	{ "udata.bytes.out",	"User Data  Bytes    (Out)" },
+	{ "udata:packets:in",	"User Data  Messages ( In)" },
+	{ "udata:packets:out",	"User Data  Messages (Out)" },
+	{ "udata:bytes:in",	"User Data  Bytes    ( In)" },
+	{ "udata:bytes:out",	"User Data  Bytes    (Out)" },
 };
 
 static const struct rate_ctr_group_desc pdpctx_ctrg_desc = {
-	.group_name_prefix = "sgsn.pdpctx",
+	.group_name_prefix = "sgsn:pdpctx",
 	.group_description = "SGSN PDP Context Statistics",
 	.num_ctr = ARRAY_SIZE(pdpctx_ctr_description),
 	.ctr_desc = pdpctx_ctr_description,

-- 
To view, visit https://gerrit.osmocom.org/5077
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7734cc42151581897d220b445984448ceb57aed
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list