This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Patch Set 4: Code-Review+1
(2 comments)
https://gerrit.osmocom.org/#/c/5063/4//COMMIT_MSG
Commit Message:
PS4, Line 9: * remove duplicate code: use function from libosmocore
: * use utility function to dump ubits
For me, both points mean the same. The second one should be enough.
https://gerrit.osmocom.org/#/c/5063/4/tests/coding/coding_test.c
File tests/coding/coding_test.c:
Line 33: #define ASSERT_TRUE(rc) \
Since the library is linked against libosmocore, I think it makes sense to use OSMO_ASSERT instead of this construction.
--
To view, visit https://gerrit.osmocom.org/5063
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c31b0954176a2c53305936a025c92a793b6d9b6
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-HasComments: Yes