[MERGED] osmo-msc[master]: cosmetic: log error when using a conn that's in release

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged.

Change subject: cosmetic: log error when using a conn that's in release
......................................................................


cosmetic: log error when using a conn that's in release

If a conn is attempted to be used when in release, log an error, but don't skip
tracking.

No current code path apparently hits this, according to msc_vlr_tests. Just
making sure that we will prominently see such errors when we introduce any.

Change-Id: I8dd20ee56ce5ad7a90fcd03a06604c383e5eed54
---
M src/libmsc/osmo_msc.c
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/osmo_msc.c b/src/libmsc/osmo_msc.c
index d55940d..2a868a8 100644
--- a/src/libmsc/osmo_msc.c
+++ b/src/libmsc/osmo_msc.c
@@ -349,7 +349,10 @@
 	OSMO_ASSERT(conn);
 
 	if (conn->in_release)
-		return NULL;
+		LOGPSRC(DREF, LOGL_ERROR, file, line,
+			"%s: MSC conn use error: using conn that is already in release (%s)\n",
+			vlr_subscr_name(conn->vsub),
+			msc_subscr_conn_use_name(balance_token));
 
 	if (balance_token != MSC_CONN_USE_UNTRACKED) {
 		uint32_t flag = 1 << balance_token;

-- 
To view, visit https://gerrit.osmocom.org/4971
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8dd20ee56ce5ad7a90fcd03a06604c383e5eed54
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>