osmo-gsm-tester[master]: OsmoBtsTrx: Integrate with OsmoPcu and OsmoSgsn

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Nov 27 13:35:35 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/5007/1/src/osmo_gsm_tester/bts_osmotrx.py
File src/osmo_gsm_tester/bts_osmotrx.py:

Line 51:         self._pcu = pcu_osmo.OsmoPcu(self.suite_run, self, self.conf)
> From my point of view the pcu is always attached to a specific bts and it's
but you are also creating a PCU in case we're not even going to test GPRS. In general code design, creating more classes from the constructor is a bad choice. E.g. for testing, for readability, avoid unintended cascades...

Alternatives: create the PCU from an explicit function (def create_pcu()), create the PCU from the general BTS startup function conditionally on whether GRPS is used, or create-if-not-exists from def pcu().


-- 
To view, visit https://gerrit.osmocom.org/5007
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I777835345355538a945599fb088630af63dc9140
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list