This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/5030/3/src/common/l1sap.c File src/common/l1sap.c: Line 1362: "DTX-DL-FSM"); If fsm_inst_alloc fails again for any other reason, we will hit the same segfault. So we need error handling here. Easiest but most drastic is an OSMO_ASSERT(lchan->tch.dtx.dl_amr_fsm), better would be a return -RSL_ERR_*. Secondly, it is certainly extremely useful to see in the log output which lchan the FSM is about. Otherwise we see FSM transitions for numerous lchans mixed together without a hint at which lchan this is all about. So it might be worth it to mangle the name and strip illegal characters. We may actually want to add such to the FSM api. In the lack of such improvements, we may want to merge this change first, but IMHO definitely needs a timely follow-up. I'd appreciate if you could afford the time to add at least error handling. -- To view, visit https://gerrit.osmocom.org/5030 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I929ce3703dc57acf8db569ae0e346265644d0b3c Gerrit-PatchSet: 3 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes